[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28037 - in trunk/subversion: include libsvn_ra_serf

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-11-27 19:09:55 CET

Daniel Rall wrote:
> On Mon, 26 Nov 2007, Garrett Rooney wrote:
>
>> On Nov 26, 2007 3:38 PM, Daniel Rall <dlr@collab.net> wrote:
>>> On Mon, 26 Nov 2007, Garrett Rooney wrote:
>>>
>>>> On Nov 26, 2007 3:00 PM, <lgo@tigris.org> wrote:
>>>>
>>>>> -static void
>>>>> +void
>>>>> encode_auth_header(const char * protocol, char **header,
>>>>> const char * data, apr_size_t data_len,
>>>>> apr_pool_t *pool)
>>>> If that isn't going to be static it needs a svn_somethingorother prefix.
>>> Dude, that's so pre-r28041. Get with the times. ;-)
>> The danger of only skimming email ;-)
>
> Thanks for the review, Garrett.

Thanks to both of you for the review and fixes.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 27 19:11:02 2007

This is an archived mail posted to the Subversion Dev mailing list.