[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for reverting broken softlinks

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-11-23 20:37:23 CET

Well, we haven't actually committed it to trunk yet, which is a first step :)

It looks like a good bug find and fix. Can you write a regression
test as well? The connection between the "revert" code and
compare_and_verify isn't immediately obvious to me, so a test is
especially nice.

--dave

On Nov 23, 2007 9:51 AM, David O'Shea <david.oshea@s3group.com> wrote:
> Any chance of including this fix in 1.4.6?
>
> Thanks,
>
> David.
>
> On 17/10/2007 08:35, David O'Shea wrote:
> > Hi,
> >
> > The attached patch fixes the case where you're trying to revert a
> > working copy with broken softlinks. Steps to reproduce the existing
> > problem are as follows:
> >
> > $ touch foo
> > $ ln -s foo bar
> > $ svn add foo bar
> > $ svn ci -m "Adding link for testing purposes."
> > $ ln -sf fish bar
> > $ svn revert bar
> >
> > This will result in the error message:
> >
> > svn: Can't open file 'bar': No such file or directory
> >
> >
> > [[[
> > Fix for reverting WC with broken softlinks.
> >
> > * subversion/libsvn_wc/questions.c
> > (compare_and_verify): Do not attempt to read untranslated special files.
> >
> > ]]]
> >
> > Regards,
> >
> > David.
> >
> --
>
> The information contained in this e-mail and in any attachments is confidential and is designated solely for the attention of the intended recipient(s). If you are not an intended recipient, you must not use, disclose, copy, distribute or retain this e-mail or any part thereof. If you have received this e-mail in error, please notify the sender by return e-mail and delete all copies of this e-mail from your computer system(s).
> Please direct any additional queries to: communications@s3group.com.
> Thank You.
> Silicon and Software Systems Limited. Registered in Ireland no. 378073.
> Registered Office: Whelan House, South County Business Park, Leopardstown, Dublin 18
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 23 20:37:33 2007

This is an archived mail posted to the Subversion Dev mailing list.