[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27617 - trunk/subversion/libsvn_fs_util

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2007-11-20 15:33:00 CET

Thanks, Fixed in r27945.

With regards
Kamesh Jayachandran

Karl Fogel wrote:
> kameshj@tigris.org writes:
>
>> --- trunk/subversion/libsvn_fs_util/mergeinfo-sqlite-index.c (original)
>> +++ trunk/subversion/libsvn_fs_util/mergeinfo-sqlite-index.c Tue Nov 6 03:49:01 2007
>> @@ -534,10 +534,10 @@
>> }
>>
>> /* A helper for svn_fs_mergeinfo__get_mergeinfo() that retrieves
>> - mergeinfo recursively (when INCLUDE_PARENTS is TRUE) for a single
>> - path. Pass NULL for RESULT if you only want CACHE to be updated.
>> - Otherwise, both RESULT and CACHE are updated with the appropriate
>> - mergeinfo for PATH. */
>> + mergeinfo recursively (when INHERIT is svn_mergeinfo_inherited or
>> + svn_mergeinfo_nearest_ancestor) for a single path. Pass NULL for RESULT
>> + if you only want CACHE to be updated. Otherwise, both RESULT and CACHE
>> + are updated with the appropriate mergeinfo for PATH. */
>> static svn_error_t *
>> get_mergeinfo_for_path(sqlite3 *db,
>> const char *path,
>>
>
> As long as you're fixing the doc string, might as well fix it to
> document every parameter. Right now, DB and REV and POOL are
> undocumented.
>
> By the way, I reviewed r27615 too, looks good (and it was simple
> enough that I could understand it without asking you more questions
> about merge-tracking :-) ).
>
> -Karl
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 20 15:37:01 2007

This is an archived mail posted to the Subversion Dev mailing list.