[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] - Fix a compiler warning on OSX

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-11-20 04:26:08 CET

I noticed this in my output. I report it only because a similar
warning in the mergeinfo.c code was fixed last week, therefore I
assume people think it is a good idea to fix these.

subversion/libsvn_subr/xml.c: In function 'svn_xml_parse':
subversion/libsvn_subr/xml.c:402: warning: format '%d' expects type
'int', but argument 5 has type 'XML_Size'

Changing the format specifier to %ld makes the warning go away. I
imagine an XML file is not likely to have a line number that is bigger
than the size of int, and I was not sure if there are some
platform-specific size differences, so I did not just blindly commit
it. Also, according to blame it looks like the code has been around a
while.

I have attached a patch with log message. If this is something we
should fix then let me know and I can commit it.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Nov 20 04:26:19 2007

This is an archived mail posted to the Subversion Dev mailing list.