[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch] Use hash for optional args with long argument list in Ruby bindings

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2007-11-18 03:58:54 CET

Hi,

In <ae6cb1100711170750l282cc602j710ed8effe67705f@mail.gmail.com>
  "Re: [patch] Use hash for optional args with long argument list in Ruby bindings" on Sat, 17 Nov 2007 07:50:03 -0800,
  "Joe Swatosh" <joe.swatosh@gmail.com> wrote:

> Okay, I committed in r27900. What about the :target_revision
> argument? Couldn't
> it reasonably be defaulted to zero?

I think :target_revision isn't needed because it seems that
:target_revision is for output. We should remove
:target_revision from argument list.

BTW, it seems that switch_editor has a bug. It uses
get_update_editor2 not get_switch_editor2. Could you fix
this too?

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 18 03:59:22 2007

This is an archived mail posted to the Subversion Dev mailing list.