[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: reasonable to keep a hash of all new node IDs in memory during a commit?

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-11-17 04:58:50 CET

On Nov 16, 2007 6:47 PM, David Glasser <glasser@davidglasser.net> wrote:
> The node-origin-in-sqlite code is now on trunk and used by FSFS. The
> cache is only populated on a miss; it should be straightforward to
> also populate it after a commit. (Specifically, during
> svn_fs_fs__commit *after* the write lock is released.)
>
> Just one question: is it OK to build up a hash in memory mapping new
> node IDs to noderev IDs, or does that violate the "don't keep
> arbitrarily large things in memory" rule? I think it should be OK
> because every new node ID has a changed-path entry, so the size of
> this hash would be no bigger than the size of a revision's
> changed-paths hash, and we keep those around in memory all the time.

I committed this in r27893, but would still appreciate the sanity check.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 17 04:59:00 2007

This is an archived mail posted to the Subversion Dev mailing list.