Re: [patch] Add -std=c89 to CFLAGS for gcc

On Thu, 30 Aug 2007, mark benedetto king wrote:

>
> On Thu, Aug 30, 2007 at 03:03:17PM -0700, Daniel Rall wrote:
> >
> > On Aug 14, 2007, at 11:09 AM, Erik Huelsmann wrote:
> >
> > > On 8/14/07, Daniel Rall <dlr@finemaltcoding.com> wrote:
> > >>
> > >> On Aug 14, 2007, at 2:38 AM, Lieven Govaerts wrote:
> > >>
> > >>> Quoting Erik Huelsmann <ehuels@gmail.com>:
> > >>>
>
> [...]
>
> > >>>>
> > >>>> PS: Is there something in my CFLAGS I can set to prevent this kind
> > >>>> of error?
> > >>>
> > >>> Adding -std=c89 should have that effect.
> > >>
> > >> Is there any particular reason why we don't add this to Makefile by
> > >> default?
> > >
> > > Thanks for asking, because I was wondering the same thing. I think we
> > > should (when we detect GCC, that is).
> >
> > How about this patch, then?
> >
> > [[[
> > * configure.in
> > (CFLAGS): Add -std=c89 when gcc is detected.
> > ]]]
> >
>
> This caused trouble in the past (see r11054).

Thanks Mark. After some research and testing, I've backed out that
change in r27869. It wasn't as helpful as hoped, and as a bonus,
broke the build of the Ruby bindings for me on Linux (FC6).