Re: [PATCH] Relative url support for all svn subcommand (that make sense)

On Nov 16, 2007 12:30 AM, David Glasser <glasser@davidglasser.net> wrote:
> On Nov 15, 2007 9:13 PM, Troy Curtis Jr <troycurtisjr@gmail.com> wrote:
> > I have implemented relative url support for every subcommand that makes sense.
> > Every command that had an existing test set has a new test function to test it
> > with relative urls. Comments?
>
> Every call to svn_wc_get_absolute_url and
> svn_wc_get_absolute_url_array from your client code passed "." as the
> wc path. I don't see how this is appropriate; you should be able to
> use
>
> $ svn switch ^/trunk /absolute/path/to/wc
>
> for example. I don't know of anything else in the client which
> defaults to current directory ignoring arguments...
>
> --dave
>
>
> --
> David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
>

Yeah I guess that's true, and obviously I gave it the option of having
the value passed in. However, I was simply thinking of the meaning of
the '^/' as the root url for the current directory. It seemed like I
thought of a couple of cases where using the values in the argument
list would be confusing but I can't think of it. I guess it does make
sense at least on those commands that always have some working copy
path to affect, like svn switch and merge.

So what makes the most sense. Given an array of targets (for a
general case) dig through and find a working copy path (if there is
one) and use it's root url, else use the current directory? Or only
look at the argument list on those functions that are guaranteed to
have a working copy path as an argument? I think that is only switch
and merge right? At least for an existing working copy. I did add
code to checkout so that you could do something like "svn co
^/branches/a ../a" while in a trunk working copy, but obviously in
that case I couldn't not use the given wc path.

Ultimately I thought it was simpler to thing of the substitution as
'root url of the current directory' since it doesn't really had any
new "features" and it's just a shortcut.

Troy

-- 
"Beware of spyware. If you can, use the Firefox browser." - USA Today
Download now at http://getfirefox.com
Registered Linux User #354814 ( http://counter.li.org/)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org