Re: [PATCH] Allow custom user agent string

Stefan Küng wrote:
> C. Michael Pilato wrote:
>> Stefan Küng wrote:
>>> Hi,
>>>
>>> The attached patch removes the fixed user-agent strings used in the svn
>>> library and replaces them with a define. That way, svn clients can set
>>> that define to a custom user-agent string when compiling the library.
>>>
>>> If the client does not define a custom user-agent string, a default
>>> ("SVN/") is used (the same as before).
>>
>> Stefan, are you aware of the fact that mod_dav_svn actually pays
>> attention
>> the User-Agent header, specifically searching for those which begin with
>> "SVN/"? This is used in the LOCK handling code and, I think, the GET
>> response handler, too.
>
> Sorry, wasn't aware of that.
> In that case, just forget the patch.
>
> There goes the nice svn-client statistics I wanted to see some day ;)

What if you simply added a note there saying, "If you expect your client to
work, keep SVN/ at the start of this string."

I mean, can "SVN/1.5.0;TortoiseSVN/1.5.1" be a valid user-agent string?

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand