[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: WC corruption after checkout on Mac

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-11-14 01:17:26 CET

On Nov 13, 2007 4:12 PM, Eric Gillespie <epg@google.com> wrote:
> - Stop unlinking files we know don't exist
> We know whether the rename failed or not; only unlink if so.
> We should probably audit other del_on_pool_cleanup use, and,
> for that matter, all unlink calls.

In this particular case it's not just "if the rename failed", it's
also if anything fails before the rename (say, the source has
inconsistent newlines). Probably just revert r17238 (or at least the
error usage; dunno about the pool changes).

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 14 01:17:35 2007

This is an archived mail posted to the Subversion Dev mailing list.