[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27780 - in trunk/subversion: include include/private libsvn_ra_local libsvn_repos mod_dav_svn svnserve

From: Blair Zajac <blair_at_orcaware.com>
Date: 2007-11-13 17:41:20 CET

Karl Fogel wrote:
> Blair Zajac <blair@orcaware.com> writes:
>> I'm just reading this comment with no review of the rest of the code,
>> but this is the first place somebody would read about this function as
>> a public consumer.
>>
>> Can you explain what this does and where the client capabilities is
>> stored and why does the repos use it?
>>
>> I presume this is passed to the start-commit script?
>
> Good point. I'll add a note to that effect.
>
>> The type of the elements in capabilities should also be stated.
>
> Ah. I thought having them in double-quotes made that clear -- but if
> one reader didn't think so, others won't either, so I'll fix it up.
>
>> I would also note that a copy of capabilities is not made, so changes
>> to it will change the usage later.
>
> Also good. One could figure it out from reading the doc string and
> from knowing that there is no way to get a pool given only an
> svn_repos_t and an apr_array_header_t... but one shouldn't have to :-).

Good point on that one. But couldn't the svn_repos_t store a pool to the
pointer it was allocated in and use that to make a copy of the capabilities?

>
> All done in r27785.

Thanks Karl, that makes it much easier to read it all in one place.

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 13 17:45:36 2007

This is an archived mail posted to the Subversion Dev mailing list.