[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug in libsvn_subr/xml.c

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2007-11-13 13:38:31 CET

On 11/13/07, Xi Wang <xi.wang@gmail.com> wrote:
> Hi,
>
> It's likely a bug found automatically by our in-lab tool for pools.

> In subversion/libsvn_subr/xml.c, a hash table (ht) is allocated from a
> subpool, and an iterator (hi) is allocated from a parent pool. Since the
> subpool is destroyed before the parent pool, the iterator (hi) is dangling
> and may be a leak.

The memory pointed to by hi isn't really leaked (since its still
allocated in a pool); it does have a longer-than-necessary lifetime.
Except for passing another pool into svn_xml_make_open_tag - which
looks like overkill to me - I don't really see a way to resolve this
issue...

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 13 13:38:58 2007

This is an archived mail posted to the Subversion Dev mailing list.