Re: svn commit: r27780 - in trunk/subversion: include include/private libsvn_ra_local libsvn_repos mod_dav_svn svnserve

kfogel@tigris.org wrote:
> Author: kfogel
> Date: Mon Nov 12 17:31:57 2007
> New Revision: 27780
>
> Log:
> Follow up to r27613 with some API improvements.
>
> Suggested by: epg
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_repos.h?pathrev=27780&r1=27779&r2=27780
> ==============================================================================
> --- trunk/subversion/include/svn_repos.h (original)
> +++ trunk/subversion/include/svn_repos.h Mon Nov 12 17:31:57 2007
> @@ -2313,6 +2313,25 @@
> apr_pool_t *pool);
>
>
> +
> +/** Capabilities **/
> +
> +/**
> + * Store in @a repos the client-reported capabilities @a capabilities,
> + * which must be allocated in memory at least as long-lived as @a repos.
> + *
> + * @note As of Subversion 1.5, there are no error conditions defined,
> + * so this always returns SVN_NO_ERROR. In future releases it may
> + * return error, however, so callers should check.

Hi Karl,

I'm just reading this comment with no review of the rest of the code, but this
is the first place somebody would read about this function as a public consumer.

Can you explain what this does and where the client capabilities is stored and
why does the repos use it?

I presume this is passed to the start-commit script?

The type of the elements in capabilities should also be stated.

I would also note that a copy of capabilities is not made, so changes to it will
change the usage later.

Regards,
Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 13 03:55:57 2007