[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27776 - branches/svnsync_ra_serf/subversion/svnsync

From: Blair Zajac <blair_at_orcaware.com>
Date: 2007-11-12 23:58:19 CET

lgo@tigris.org wrote:
> Author: lgo
> Date: Mon Nov 12 13:48:55 2007
> New Revision: 27776
>
> Log:
> Small code improvement.
>
> Suggested by: dlr
>
> * subversion/svnsync/main.c
> (filter_func_t): Return svn_boolean_t instead of int.
> (filter_exclude_date_author_sync,
> filter_include_date_author_sync): Update to match filter_func_t declaration.
>
>
> Modified:
> branches/svnsync_ra_serf/subversion/svnsync/main.c
>
> Modified: branches/svnsync_ra_serf/subversion/svnsync/main.c
> URL: http://svn.collab.net/viewvc/svn/branches/svnsync_ra_serf/subversion/svnsync/main.c?pathrev=27776&r1=27775&r2=27776
> ==============================================================================
> --- branches/svnsync_ra_serf/subversion/svnsync/main.c (original)
> +++ branches/svnsync_ra_serf/subversion/svnsync/main.c Mon Nov 12 13:48:55 2007
> @@ -383,7 +383,7 @@
> * should be filtered out (ie. not be copied to the target list), or FALSE if
> * not.
> */
> -typedef int (*filter_func_t)(const char *key);
> +typedef svn_boolean_t (*filter_func_t)(const char *key);
>
> /* Make a new set of properties, by copying those properties in PROPS for which
> * the filter FILTER returns FALSE.
> @@ -1149,7 +1149,7 @@
> }
>
> /* Filter out svn:date and svn:author properties. */
> -static int filter_exclude_date_author_sync(const char* key)
> +static svn_boolean_t filter_exclude_date_author_sync(const char* key)

As a style, we put the * next to the variable name, not the type name, since in
this example:

Foo* a, b;

b is a Foo, not a Foo *.

So it should be

static svn_boolean_t filter_exclude_date_author_sync(const char *key)

Regards,
Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 13 00:01:02 2007

This is an archived mail posted to the Subversion Dev mailing list.