[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] AttributeError in cmdline tests

From: Stephen Butler <sbutler_at_elego.de>
Date: 2007-11-12 11:56:21 CET

Hi folks,

Here's a simple patch for avoiding a bogus Attribute error in a few
test cases. A follow-up to r26716. (Split output
handling/verification code into the new "verify" module)

It's not too urgent, because the AttributeError helpfully tells us what the
real test error is:

"C:\build\subversion\subversion/tests/cmdline/commit_tests.py", line
857, in hook_test
         raise svntest.actions.SVNUnexpectedOutput("hook logfile %s
not found")\
     AttributeError: 'module' object has no attribute 'SVNUnexpectedOutput'
     FAIL: commit_tests.py 15: hook testing



Use the SVN* exception classes in verify.py rather than in action.py.
They were moved in r26716. On test success there's no warning, but on
test failure we get an AttributeError. This is really just a nit,
because the exception classes are simply names.

* subversion/tests/cmdline/import_tests.py
* subversion/tests/cmdline/prop_tests.py
* subversion/tests/cmdline/basic_tests.py
* subversion/tests/cmdline/commit_tests.py
* subversion/tests/cmdline/authz_tests.py


Stephen Butler | Software Developer
elego Software Solutions GmbH
Gustav-Meyer-Allee 25 | 13355 Berlin | Germany
fon: +49 30 2345 8696 | mobile: +49 163 25 45 015
fax: +49 30 2345 8695 | http://www.elegosoft.com
Geschäftsführer: Olaf Wagner | Sitz der Gesellschaft: Berlin
Amtsgericht Charlottenburg HRB 77719 | USt-IdNr: DE163214194

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Nov 12 11:56:38 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.