[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r27713 - trunk/subversion/tests/libsvn_subr

From: Paul Burba <pburba_at_collab.net>
Date: 2007-11-08 21:51:26 CET

> -----Original Message-----
> From: dglasser@gmail.com [mailto:dglasser@gmail.com] On
> Behalf Of David Glasser
> Sent: Thursday, November 08, 2007 2:41 PM
> To: Blair Zajac
> Cc: dev@subversion.tigris.org; pburba@tigris.org
> Subject: Re: svn commit: r27713 - trunk/subversion/tests/libsvn_subr
>
> On Nov 8, 2007 9:52 AM, Blair Zajac <blair@orcaware.com> wrote:
> > pburba@tigris.org wrote:
> > > Author: pburba
> > > Date: Thu Nov 8 09:08:34 2007
> > > New Revision: 27713
> > >
> > > Log:
> > > Make C test of svn_mergeinfo_parse() a bit more robust.
> > >
> > > * subversion/tests/libsvn_subr/mergeinfo-test.c
> > > (verify_mergeinfo_parse): Enable testing of more than
> just the first range
> > > in a set.
> >
> > Hi Paul,
> >
> > I'm now getting these compiler warnings in this file:
> >
> > gcc -DLINUX=2 -D_REENTRANT -D_XOPEN_SOURCE=500 -D_BSD_SOURCE
> > -D_SVID_SOURCE -D_GNU_SOURCE -g -Wall -pipe -I/usr/include/xmltok
> > -I/usr/include/openssl -Wall -g -pthread -D_LARGEFILE64_SOURCE
> > -DNE_LFS -std=c89 -Wpointer-arith -Wwrite-strings -Wshadow
> -DSVN_DEBUG -DAP_DEBUG -I./subversion/include
> > -I./subversion -I/usr/include/neon -I/usr/include/apr-0
> -I/usr/include/apr-0
> > -I/usr/include -o subversion/tests/libsvn_subr/mergeinfo-test.o -c
> > subversion/tests/libsvn_subr/mergeinfo-test.c
> > subversion/tests/libsvn_subr/mergeinfo-test.c: In function
> 'verify_mergeinfo_parse':
> > subversion/tests/libsvn_subr/mergeinfo-test.c:77: warning: passing
> > argument 4 of 'apr_hash_this' from incompatible pointer type
> > subversion/tests/libsvn_subr/mergeinfo-test.c:99: warning:
> comparisons
> > like X<=Y<=Z do not have their mathematical meaning
> > subversion/tests/libsvn_subr/mergeinfo-test.c:99: warning:
> comparisons
> > like X<=Y<=Z do not have their mathematical meaning
> > subversion/tests/libsvn_subr/mergeinfo-test.c:125:5: warning: "/*"
> > within comment
>
> I fixed the type and comment warnings in r27715. I'm not
> sure what the intended logic actually is for the
>
> if (j < MAX_NBR_RANGES - 1
> && !(expected_ranges[j].start
> == expected_ranges[j].start
> == expected_ranges[j].inheritable == 0))
>
> block.

Sorry, brain cramp. Fixed in r27724.

Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 8 21:56:30 2007

This is an archived mail posted to the Subversion Dev mailing list.