[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r27700 - in trunk/subversion: svnadmin svndumpfilter

From: Paul Burba <pburba_at_collab.net>
Date: 2007-11-08 17:35:21 CET

Hi Blair,

Not sure if you noticed or not, but this commit breaks the Win32
buildbot (and my own box):

http://www.mobsol.be/buildbot/win32-xp%20VS2005/builds/2736/step-Build/0

I took a (admittedly brief) look but couldn't figure out how to stop the
warning but permit a successful build.

Are you able to build on Win32 with this change?

Paul

> -----Original Message-----
> From: blair@tigris.org [mailto:blair@tigris.org]
> Sent: Wednesday, November 07, 2007 11:40 PM
> To: svn@subversion.tigris.org
> Subject: svn commit: r27700 - in trunk/subversion: svnadmin
> svndumpfilter
>
> Author: blair
> Date: Wed Nov 7 20:40:22 2007
> New Revision: 27700
>
> Log:
> Attempt to fix this compiler warning from Visual Studio 2005:
>
> warning C4042: 'open_fn' : has bad storage class
>
> See http://msdn2.microsoft.com/en-us/library/z9d31kt4(vs.80).aspx
>
> * subversion/svnadmin/main.c,
> * subversion/svndumpfilter/main.c:
> (create_stdio_stream):
> Do not declare the function pointer type with APR_DECLARE.
>
>
> Modified:
> trunk/subversion/svnadmin/main.c
> trunk/subversion/svndumpfilter/main.c
>
> Modified: trunk/subversion/svnadmin/main.c
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/svnadmin/mai
> n.c?pathrev=27700&r1=27699&r2=27700
> ==============================================================
> ================
> --- trunk/subversion/svnadmin/main.c (original)
> +++ trunk/subversion/svnadmin/main.c Wed Nov 7 20:40:22 2007
> @@ -84,8 +84,7 @@
> /* Helper to open stdio streams */
> static svn_error_t *
> create_stdio_stream(svn_stream_t **stream,
> - APR_DECLARE(apr_status_t) open_fn(apr_file_t **,
> - apr_pool_t *),
> + apr_status_t open_fn(apr_file_t **,
> apr_pool_t *),
> apr_pool_t *pool)
> {
> apr_file_t *stdio_file;
>
> Modified: trunk/subversion/svndumpfilter/main.c
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/svndumpfilte
> r/main.c?pathrev=27700&r1=27699&r2=27700
> ==============================================================
> ================
> --- trunk/subversion/svndumpfilter/main.c (original)
> +++ trunk/subversion/svndumpfilter/main.c Wed Nov 7 20:40:22 2007
> @@ -51,8 +51,7 @@
> */
> static svn_error_t *
> create_stdio_stream(svn_stream_t **stream,
> - APR_DECLARE(apr_status_t) open_fn(apr_file_t **,
> - apr_pool_t *),
> + apr_status_t open_fn(apr_file_t **,
> apr_pool_t *),
> apr_pool_t *pool)
> {
> apr_file_t *stdio_file;
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 8 17:53:43 2007

This is an archived mail posted to the Subversion Dev mailing list.