[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: start-commit.bat

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-11-08 01:52:27 CET

"D.J. Heap" <djheap@gmail.com> writes:
> On Nov 7, 2007 5:18 PM, Karl Fogel <kfogel@red-bean.com> wrote:
> [snip]
>> Thank you for reporting this.
>>
>> Does anyone know what a portable separator char is? The original
>> issue suggested ";". Maybe I should have done that, but is there
>> anywhere where it causes a problem? What about plain colon ":" ?
>
> A comma works fine if the whole list is double-quoted, and we should
> probably be quoting all parameters anyway to handle spaces in paths,
> etc. if APR isn't already.

Hmmm. But this isn't going through a shell. If we put double quotes
around something, then the double quotes will actually be there in the
argument, right? That is, if you write your hook program in C, then
argv[3][0] == '"', no?

In other words, is the behavior different depending on whether you
write start-commit.bat vs start-commit.c? And if so, should be be
putting double quotes around args only conditionally?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 8 01:52:40 2007

This is an archived mail posted to the Subversion Dev mailing list.