[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27613 - in branches/issue-2991-dev/subversion: include include/private libsvn_ra_local libsvn_ra_neon libsvn_ra_serf libsvn_ra_svn libsvn_repos mod_dav_svn svnserve tests/cmdline

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-11-07 20:07:04 CET

On 11/5/07, kfogel@tigris.org <kfogel@tigris.org> wrote:
> Author: kfogel
> Date: Mon Nov 5 22:20:04 2007
> New Revision: 27613

[This has since been merged to trunk.]

> Modified: branches/issue-2991-dev/subversion/libsvn_repos/hooks.c
> URL: http://svn.collab.net/viewvc/svn/branches/issue-2991-dev/subversion/libsvn_repos/hooks.c?pathrev=27613&r1=27612&r2=27613
> ==============================================================================
> --- branches/issue-2991-dev/subversion/libsvn_repos/hooks.c (original)
> +++ branches/issue-2991-dev/subversion/libsvn_repos/hooks.c Mon Nov 5 22:20:04 2007
> @@ -536,6 +536,7 @@
> svn_error_t *
> svn_repos__hooks_start_commit(svn_repos_t *repos,
> const char *user,
> + apr_array_header_t *capabilities,
> apr_pool_t *pool)
> {
> const char *hook = svn_repos_start_commit_hook(repos, pool);
> @@ -548,11 +549,15 @@
> else if (hook)
> {
> const char *args[4];
> + char *capabilities_string = svn_cstring_join(capabilities, ",", pool);
> + /* Get rid of that annoying final comma. */
> + capabilities_string[strlen(capabilities_string) - 1] = '\0';

I think this overwrites some random bit of memory if the capabilities
array is empty.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 7 20:08:08 2007

This is an archived mail posted to the Subversion Dev mailing list.