[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27648 - in trunk/subversion: libsvn_repos svnserve

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-11-07 07:32:25 CET

On 11/6/07, kfogel@tigris.org <kfogel@tigris.org> wrote:
> Author: kfogel
> Date: Tue Nov 6 22:00:47 2007
> New Revision: 27648
>
> Log:
> Documentation changes only.
>
> * subversion/libsvn_repos/repos.h
> (svn_repos_t.capabilities): Add explanatory note.
>
> * subversion/svnserve/serve.c
> (find_repos): Anticipate a likely confusion by changing wording.
>
>
> Modified:
> trunk/subversion/libsvn_repos/repos.h
> trunk/subversion/svnserve/serve.c
>
> Modified: trunk/subversion/libsvn_repos/repos.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_repos/repos.h?pathrev=27648&r1=27647&r2=27648
> ==============================================================================
> --- trunk/subversion/libsvn_repos/repos.h (original)
> +++ trunk/subversion/libsvn_repos/repos.h Tue Nov 6 22:00:47 2007
> @@ -120,7 +120,13 @@
>
> /* If non-null, a list of all the capabilities the client (on the
> current connection) has self-reported. Each element is a
> - 'const char *', one of SVN_RA_CAPABILITY_*. */
> + 'const char *', one of SVN_RA_CAPABILITY_*.
> +
> + Note: it is somewhat counterintuitive that we store the client's
> + capabilities, which are session-specific, on the repository
> + object. You'd think the capabilities here would represent the
> + *repository's* capabilities, but no, they represent the
> + client's -- we just don't have any other place to persist them. */
> apr_array_header_t *capabilities;

Given that it is admittedly counterintuitive, how about calling the
field client_capabilities?

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 7 07:34:14 2007

This is an archived mail posted to the Subversion Dev mailing list.