[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: revert_tests 15 and 17 fail in svn_ra_local__get_session_url

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-11-06 20:33:38 CET

C. Michael Pilato wrote:
> C. Michael Pilato wrote:
>> C. Michael Pilato wrote:
>>> Hrm... I wonder if svn_ra_local__reparent() is to blame for this problem.
>>> It does this:
>>>
>>> svn_stringbuf_set(baton->fs_path,
>>> svn_path_uri_decode(url + strlen(baton->repos_url),
>>> pool));
>>>
>>> But in the case where we are asking to reparent to the same URL we were
>>> already at, won't that result in an empty fs_path? This function should be
>>> checking the result for emptiness, and making sure that fs_path has a
>>> leading slash.
>> By the way, I'm "on" this right now.
>
> Okay. r27631 makes 'fs_path' *always* have a leading slash, and *should*
> take care of these test failures you guys were seeing. Can you confirm?

My failures of merge test 74 were fixed by this commit. Thanks!

-Hyrum

Received on Tue Nov 6 20:35:42 2007

This is an archived mail posted to the Subversion Dev mailing list.