Re: [PATCH] Re: Flushing directory log accumulator during pool cleanup (Re: svn commit: r23342 - trunk/subversion/libsvn_wc)

On 11/6/07, Philip Martin <philip@codematters.co.uk> wrote:
> Philip Martin <philip@codematters.co.uk> writes:
>
> > The original change raises a few questions: suppose a directory
> > contains 2000 files (I think GCC's ADA directory is about this size),
> > does the client now hold 2000 logfiles in memory? How much memory
> > does that take? Perhaps we should limit the number of log files held
> > in memory?
>
> A crude test shows that trunk uses a little bit more memory than 1.4
> but is faster, I'm happy with that.

So to clarify: you'd be OK with just applying the patch as posted? Or
should I implement the idea of adding a boolean which represents
whether or not the buffer is flushable?

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org