Re: svn commit: r27607 - in trunk/subversion: include libsvn_fs libsvn_fs_base libsvn_fs_fs libsvn_repos libsvn_subr

On 11/5/07, Blair Zajac <blair@orcaware.com> wrote:
> glasser@tigris.org wrote:
> > Author: glasser
> > Date: Mon Nov 5 16:45:46 2007
> > New Revision: 27607
> >
> > Log:
> > Add fs- and repos-level APIs to change multiple transaction properties
> > atomically.
>
>
> > +/** Change, add, and/or delete transaction property values in
> > + * transaction @a txn. @a props is an array of <tt>svn_prop_t</tt>
> > + * elements. Do any necessary temporary allocation in @a pool.
> > + *
> > + * @since New in 1.5.
> > + */
> > +svn_error_t *svn_fs_change_txn_props(svn_fs_txn_t *txn,
> > + apr_array_header_t *props,
> > + apr_pool_t *pool);
>
> This description isn't too clear to me. Could you add a section describing that
> this is effectively an efficient way of calling svn_fs_change_txn_prop()
> multiple times and it has the same behavior to remove elements (to pass NULL)?
>
> I had to check the code to see that's what it was doing.
>
> BTW, the reason I'm asking this new method was that this could have complete
> replacement schematics in that props is the complete list of new props, but
> that's not what it does.

Thanks for the review. r27608.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org