Re: [PATCH] Re: Flushing directory log accumulator during pool cleanup (Re: svn commit: r23342 - trunk/subversion/libsvn_wc)

"David Glasser" <glasser@davidglasser.net> writes:

> On 11/5/07, Philip Martin <philip@codematters.co.uk> wrote:
>>
>> Your alternate implementation sounds much better: as I understand it
>> your proposed patch means that if a large update is interrupted there
>> could be lots of log "files" in memory corresponding to megabytes of
>> downloaded data and effectively all this data would be lost.
>
> That's true.
>
> On the other hand, if you're interrupting an operation, do you really
> want megabytes worth of work to be done before the process finishes?

I think yes. As I understand it the log files are mainly about moving
stuff into place from the tmp directory and updating the entries file,
that's relatively quick compared to downloading large amounts of data.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 6 01:58:35 2007