[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch] make it easy for the Ruby bindings tests to use a greek tree

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2007-11-05 11:31:00 CET

Hi,

In <ae6cb1100711041013x5ae99f44rc75bfe7cbe088c8e@mail.gmail.com>
  "[patch] make it easy for the Ruby bindings tests to use a greek tree" on Sun, 4 Nov 2007 10:13:35 -0800,
  "Joe Swatosh" <joe.swatosh@gmail.com> wrote:

> I needed a directory with subdirectories and files at several levels for
> testing the depth argument with the property methods on Svn::Client::Context.
> The Greek tree seemed a natural way to get what I needed. And it occurred to
> me it might be easier to describe what is going on to non-Ruby SVN folks if
> it where done with a Greek tree.
>
> [[[
>
> Provide a simple way for test writers to create a Greek tree for testing, plus
> some helper methods to access the files and directories in the working copy
> and the repository.
>
> ]]]
>
> * subversion/bindings/swig/ruby/test/util.rb
> (SvnTestUtil#setup_basic): Define constants for the greek tree.
> (SvnTestUtil::GreekTree): New constant
> (SvnTestUtil#setup_greek_tree, SvnTestUtil.greek_constants_defined?,
> SvnTestUtil.define_greek_constants, SvnTestUtil#wc_path_for,
> SvnTestUtil#uri_for): New methods

I have some comments (coding style, approach and so on) but
you can commit this. We can improve this after you commit.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 5 11:31:22 2007

This is an archived mail posted to the Subversion Dev mailing list.