Jack Repenning wrote:
>
> On Oct 15, 2007, at 7:12 PM, David Glasser wrote:
>
>> Should [svn changelist '' foo] give an error, or just give the same
>> message as
>> "svn cl --remove"?
>
> It doesn't seem to me that one could say, with a straight face,
> "changelist '' is a handy alias for changelist --remove." It's not
> convincing UI, it just looks like something that happened because no
> one thought about the possibility. (Which is, of course, not too
> surprising, since ...) So I'd say it would be better to return an error.
>
> Are there any rules about changelist names? Total length, forbidden
> characters, anything like that? There seem to be. For instance, I
> tried sucking the entire content of some random file (contains the
> output of "du /", for some reason) in as the cl name and got "Error
> resolving case," whatever that means. So, if I can't have a cl whose
> name is the output of "du /", it's not unreasonable also to forbid a cl
> named ''.
>
> It might even be a good thing if these rules were a bit more strict.
[snip: example of multi-line changelist name]
Yes, we ought to restrict changelist names to something sane. I propose the
same rules that apply to property names. (Can't remember what those actual
rules are, but it's a very similar application so almost certainly the same
rules would be sensible.)
Fortunately it's not nearly as important as properties, because changelist
names are only local and never transmitted to the repository (I assume), but
still it seems wise.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 5 02:01:54 2007