[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: changelist removal on commit

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: 2007-11-03 21:50:44 CET

On 11/3/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> Hi,
>
> There's one small issue I have with how changelists are kept/removed on
> commits: currently, the changelist is only removed on a commit if the
> commit is actually done on that particular changelist (and if the flag
> is not set to keep the changelist).
>
> But I think it would be better if after the commit, all affected files
> have their changelists removed, no matter if the commit was done by
> specifying a changelist or not.
>
> This would make it more consistent. The '--keep-changelist' argument
> wouldn't be dependent on the '--changelist ARG' parameter.
>
> I'm having the following workflow in mind:
> * user starts working on an issue, modifies files
> * adds files to changelist
> * tests issue, changes some more code, and one or more other files
> * user forgets to add those to the changlist for that issue
> * user commits files belonging to the issue, forgets about the
> changelist set
>
> now, the files (even though they're committed and now with status
> 'normal') still belong to the changelist the user set before. The next
> time one of those files get modified, they will show up in the 'svn st
> -v' with a changelist name the user might have completely forgotten by then.

I'm misunderstanding, probably because I can't reproduce the behavior
you're talking about. Look at my transcript:

[sussman@BenBook:~/scratch/wc]$ svn cl lalala cvs2cl.pl
Path 'cvs2cl.pl' is now a member of changelist 'lalala'.
[sussman@BenBook:~/scratch/wc]$ svn cl lalala newfile
Path 'newfile' is now a member of changelist 'lalala'.
[sussman@BenBook:~/scratch/wc]$ echo "moo" >> newfile
[sussman@BenBook:~/scratch/wc]$ echo "blah" >> cvs2cl.pl
[sussman@BenBook:~/scratch/wc]$ svn st

--- Changelist 'lalala':
M cvs2cl.pl
M newfile
[sussman@BenBook:~/scratch/wc]$ svn ci newfile -m aoeu
Sending newfile
Transmitting file data .
Committed revision 17.
[sussman@BenBook:~/scratch/wc]$ svn st

--- Changelist 'lalala':
M cvs2cl.pl

Notice that I forgot to specify --changelist to 'svn commit'.
According to your email, you're saying that my committed file still
belongs to a changelist. But that's not the case -- any committed
targets lose their changelist membership, whether you specify
--changelist to 'svn commit' or not.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 3 21:50:52 2007

This is an archived mail posted to the Subversion Dev mailing list.