Re: Asking for documentation

On Friday 02 November 2007 Karl Fogel wrote:
> Philipp Marek <philipp@marek.priv.at> writes:
> > Most of the path arguments (even the lock_tokens) can be assumed to be
> > UTF-8; but is that true of the author, commit date and so on, too?
> Yes, I would assume so. If not, it's probably an unintentional bug,
> as UTF-8 is The Standard in Subversion's APIs.
>
> > I'd like to ask for a little clarification, possibly just a
> >
> > /* Every (char*) below is UTF8, except where explicitly noted. */
> >
> > at the top of the file.
> That seems reasonable, yep. (Could you supply a patch?)
Here you are:

[[[
   
  * subversion/include/svn_ra.h: Clarify parameter encoding.

]]]

Index: subversion/include/svn_ra.h
===================================================================
--- subversion/include/svn_ra.h (Revision 27580)
+++ subversion/include/svn_ra.h (Arbeitskopie)
@@ -40,6 +40,10 @@ extern "C" {

 /* Misc. declarations */

+/* All (char*) are encoded as UTF-8; all URL values are URI-encoded, ie.
+ * a '%' is represented as "%25". */
+
+
 /**
  * Get libsvn_ra version information.
  *

> > And furthermore, is it true that all URLs passed therein are used as-is?
> > Or must they already be encoded in some form?
>
> I assume they're just URI-encoded.
A small test seems to confirm that.

Regards,

Phil

-- 
Versioning your /etc, /home or even your whole installation?
             Try fsvs (fsvs.tigris.org)!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org