[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27424 - in trunk/subversion: libsvn_ra_serf tests/cmdline

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-10-31 05:52:37 CET

lgo@tigris.org writes:
> Log:
> ra_serf: Fix issue #2993: checkout the correct version of the file. If the
> file was out-of-date this will at least return the correct error message.

Yay!

> --- trunk/subversion/libsvn_ra_serf/commit.c (original)
> +++ trunk/subversion/libsvn_ra_serf/commit.c Fri Oct 26 08:23:40 2007
> @@ -433,10 +433,74 @@
> return SVN_NO_ERROR;
> }
>
> +
> +static svn_error_t *
> +get_version_url(svn_ra_serf__session_t *session,
> + svn_ra_serf__connection_t *conn,
> + const char *name,
> + svn_revnum_t base_revision,
> + const char *parent_vsn_url,
> + const char **checked_in_url,
> + apr_pool_t *pool)
> +{
> +
> + [...]

Heh. Because get_version_url() was moved within the file, as well as
modified, it's hard to see the diff. I'm not saying you should have
done things differently -- it had to be moved -- it's just too bad.

Unfortunately, ra_serf is not great about documenting its internal
static functions, but when we're exploding a single parameter ('dir')
to a bunch of parameters, it would be a real help to document the
rewritten function...

I tried it in r27515, please let me know if it reads right to you.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 31 05:52:50 2007

This is an archived mail posted to the Subversion Dev mailing list.