[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27455 - trunk/subversion/libsvn_client

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-10-29 18:39:54 CET

Daniel L. Rall wrote:
> On Mon, 29 Oct 2007, kameshj@tigris.org wrote:
>
>> Author: kameshj
>> Date: Mon Oct 29 06:02:21 2007
>> New Revision: 27455
>>
>> Log:
>> Code refactor.
>>
>> * subversion/libsvn_client/merge.c
>> (svn_client_merge_peg3): Assign iteration independent 'merge_cmd_baton'
>> members out of iteration loop.
>> Call do_merge with FALSE for 'three way merge' rather than indirectly via
>> merge_cmd_baton.
>
> This is inscrutable -- FALSE what?

I think he means, "Pass FALSE as the value of the three_way_merge parameter
of do_merge() instead of consulting the merge_cmd_baton", rather the way the
diff indicates:

>> @@ -4663,7 +4669,7 @@
>> URL2,
>> range.end,
>> is_rollback,
>> - merge_cmd_baton.target_missing_child,
>> + FALSE,
>> target_wcpath,
>> adm_access,
>> depth,

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Mon Oct 29 19:01:27 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.