Re: [PATCH-REVIEW] Relative URL support for info command
From: Stefan Sperling <stsp_at_elego.de>
Date: 2007-10-27 19:07:45 CEST
On Sat, Oct 27, 2007 at 10:57:46AM -0500, Troy Curtis Jr wrote:
I had a quick look over it.
Found nothing bad, except this piece:
First, you are missing a space after 'if'.
Second, you could simply do this instead:
"If (true) return true; else return false;" is redundant.
But (as I assume) in case anyone ever swaps the values of TRUE and
I think this looks ridiculous as well but it's being used
> My function prototypes are not properly documented yet
My advice: Don't do this! Instead:
Document your functions *before* writing them.
Then keep the docs in sync with the code whenever you change
This helps you keep thinking about what you're doing, and you
The docs also help others because they explain your intentions.
The amount and quality of the documentation inside the Subversion
Lack of docs makes your code less accessible.
-- Stefan Sperling <firstname.lastname@example.org> Software Developer elego Software Solutions GmbH HRB 77719 Gustav-Meyer-Allee 25, Gebaeude 12 Tel: +49 30 23 45 86 96 13355 Berlin Fax: +49 30 23 45 86 95 http://www.elego.de Geschaeftsfuehrer: Olaf Wagner
This is an archived mail posted to the Subversion Dev mailing list.