[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: FW: Multi-path updates

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-10-25 23:46:26 CEST

"Miller, Eric" <Eric.Miller@amd.com> writes:
> I'm sorry, I should have posted Erik's response in here as well. He
> seems to think it is due to the svn_sleep_for_timestamp, and I think
> that is at least part of the problem.
>
> Reviewing update.c, I don't understand why the sleep is *inside* the
> path loop. Once inside that loop it shouldn't matter if the timestamps
> are the same or not (as it does not matter with a hierarchical run).

Actually, I don't think that's what the code does.

Looking at subversion/libsvn_client/update.c:svn_client_update3(), it
passes '&sleep' to svn_client__update_internal(). This happens inside
the path loop.

When svn_client__update_internal() gets a non-NULL boolean pointer, it
doesn't sleep, it just sets the boolean, to indicate to the caller
that a sleep is required. The 'sleep_here' local var remains FALSE.
(svn_client__update_internal() will sleep unconditionally in the event
of an error, but presumably that's not what's happening here.)

Note also that the call to svn_client__handle_externals() is passed
the same boolean pointer, and does the same thing with it; no actual
sleeping happens in externals.c.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 25 23:46:37 2007

This is an archived mail posted to the Subversion Dev mailing list.