On 10/25/07, David Glasser <glasser@davidglasser.net> wrote:
> On 10/24/07, David Glasser <glasser@davidglasser.net> wrote:
> > Now ready for review. (Ben has promised me some in-person review time
> > tomorrow too :-) but the more eyes the better, as this is a big
> > change.)
> >
> > A few outstanding questions:
> >
> > There's this part where I filter out svn:entry:* props from being
> > copied. How about svn:wc:* props? I haven't tested this with DAV
> > yet.
> >
> > Am I being careful to use revert-base instead of text-base everywhere
> > necessary? I don't think I'm regressing anywhere but there might be
> > some pre-existing problems. For example, should svn_wc__merge_props
> > be considering using revert-props?
> >
> > Some stuff in add_file_with_history should be moved into a subpool and cleared.
> >
> > There's still the issue in locate_copyfrom where we are making a brand
> > new adm_access instead of using the set we already have, and not
> > taking out a write lock.
>
> Oh, and of course: there should be more tests. At the very least,
> something should be testing translations, and the replace/revert-base
> cases...
I committed this patch in r27377, because it does pass tests and that
will make it easier for me to start working on the ambient_depth
refactoring; however, the above points are still worth considering.
--dave
--
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 25 19:48:50 2007