[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [psvn] [PATCH] preference to automatically show the diff when you run commit

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-10-23 19:36:21 CEST

Me too. Patch looks good, +1.

On Tue, 23 Oct 2007, David Glasser wrote:

> I always like to see the diff of what I'm committing. Sure, I can hit
> C-c C-d, but I *always* like to see it. How does this look?
>
> [[[
> * contrib/client-side/emacs/psvn.el
> (svn-log-edit-show-diff-for-commit): New customizable variable,
> controlling whether...
> (svn-status-commit): ... we show a diff when popping up the commit buffer.
> ]]]
>
> Index: emacs-d/site-lisp/psvn.el
> ===================================================================
> --- emacs-d/site-lisp/psvn.el (revision 166)
> +++ emacs-d/site-lisp/psvn.el (working copy)
> @@ -238,6 +238,10 @@ of the `svn-log-edit-buffer-name' buffer
> "*Insert the filelist to commit in the *svn-log* buffer"
> :type 'boolean
> :group 'psvn)
> +(defcustom svn-log-edit-show-diff-for-commit t
> + "*Show the diff being committed when you run `svn-status-commit.'."
> + :type 'boolean
> + :group 'psvn)
> (defcustom svn-log-edit-use-log-edit-mode
> (and (condition-case nil (require 'log-edit) (error nil)) t)
> "*Use log-edit-mode as base for svn-log-edit-mode
> @@ -3970,7 +3974,9 @@ If no files have been marked, commit rec
> (svn-log-edit-show-files-to-commit)
> (svn-status-pop-to-commit-buffer)
> (when svn-log-edit-insert-files-to-commit
> - (svn-log-edit-insert-files-to-commit))))
> + (svn-log-edit-insert-files-to-commit))
> + (when svn-log-edit-show-diff-for-commit
> + (svn-log-edit-svn-diff nil))))
>
> (defun svn-status-pop-to-commit-buffer ()
> "Pop to the svn commit buffer.
>
>
> --
> David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

  • application/pgp-signature attachment: stored
Received on Tue Oct 23 19:36:41 2007

This is an archived mail posted to the Subversion Dev mailing list.