Re: [PATCH] Re: strange behavior when dealing with copied files repos/wc diffs

On 10/23/07, Karl Fogel <kfogel@red-bean.com> wrote:
> "Hyrum K. Wright" <hyrum_wright@mail.utexas.edu> writes:
> > Ping... have any of the full committers had a chance to look at this
> > patch? If nothing happens, I'll put it in the issue tracker.
>
> +1 for Charles Acknin to commit. But Charles, are you sure the
> "-rBASE" makes a difference here, since you already backdated the
> working copy to r1? If you remove the -rBASE, does anything change?

Without BASE the diff would be against WORKING. But you're right,
here we have no local mods so this doesn't change anything in the
output.

> The right way to test -rBASE is to make some local mods right before
> diffing, and then ensure that they *don't* show up in the diff, I
> think. Feel free to tweak the test to do that.

The purpose of this test is not to ensure no local mods diff show up
because the BASE keyword is there. I changed the test to reflect a
repos->wc diff instead since there's no reason it be a repos->base one
though.

Committed in r27324.

Charles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Oct 23 17:16:59 2007