[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix build with new versions of glibc

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-10-22 23:45:47 CEST

Daniel Rall wrote:
> On Sep 13, 2007, at 6:55 AM, David James wrote:
>> On 9/13/07, Joe Orton <jorton@redhat.com> wrote:
>>> Recent releases of glibc define "open" in unistd.h as a macro, to allow
>>> the detection at compile time of open() invocations which have undefined
>>> behaviour (omitting the mode parameter when required, notably). This is
>>> explicitly permitted by the POSIX specification for all function call
>>> interfaces it defines.
>>> The SVN build breaks with these new glibc releases - in places where
>>> "foo->open(" is used, the "open(" part gets macro-expanded to
>>> something... undesirable. The patch below prevents that macro expansion
>>> and fixes the build.
>> Nice fix. Thanks for fixing header_wrappers.py as well.
>> +1 from me on your patch.
> +1 to commit.

Did this ever get committed?


Received on Mon Oct 22 23:46:43 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.