[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27215 - in trunk/subversion: libsvn_ra_neon tests/cmdline

From: Daniel L. Rall <dlr_at_finemaltcoding.com>
Date: 2007-10-22 10:30:28 CEST

Shouldn't we also set request->err = SVN_NO_ERROR?

Failing to do so might cause a problem now, but could later.

On Tue, 16 Oct 2007, lgo@tigris.org wrote:

> Author: lgo
> Date: Tue Oct 16 08:34:00 2007
> New Revision: 27215
>
> Log:
> Follow up r27190, fix copy_tests.py 25: the server is returning an error
> message in the 404 response. Since the 404 response is allowed, we're just
> ignoring the error, but it still has to be cleared.
>
> * subversion/libsvn_ra_neon/commit.c
> (do_checkout): clear the error stored in request when we're ignoring it.
>
> * subversion/tests/cmdline/copy_tests.py
> (url_to_non_existent_url_path): the error message that's returned has
> changed a bit, as ra_neon is now opening the target path directly instead
> opening its parents first.
>
>
> Modified:
> trunk/subversion/libsvn_ra_neon/commit.c
> trunk/subversion/tests/cmdline/copy_tests.py
>
> Modified: trunk/subversion/libsvn_ra_neon/commit.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra_neon/commit.c?pathrev=27215&r1=27214&r2=27215
> ==============================================================================
> --- trunk/subversion/libsvn_ra_neon/commit.c (original)
> +++ trunk/subversion/libsvn_ra_neon/commit.c Tue Oct 16 08:34:00 2007
> @@ -433,6 +433,9 @@
> allow_404 ? 404 /* Not Found */ : 0,
> pool));
>
> + if (allow_404 && *code == 404 && request->err)
> + svn_error_clear(request->err);
> +
> *locn = svn_ra_neon__request_get_location(request, pool);
> svn_ra_neon__request_destroy(request);
>
>
> Modified: trunk/subversion/tests/cmdline/copy_tests.py
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/tests/cmdline/copy_tests.py?pathrev=27215&r1=27214&r2=27215
> ==============================================================================
> --- trunk/subversion/tests/cmdline/copy_tests.py (original)
> +++ trunk/subversion/tests/cmdline/copy_tests.py Tue Oct 16 08:34:00 2007
> @@ -1705,7 +1705,7 @@
>
> # Look for both possible versions of the error message, as the DAV
> # error is worded differently from that of other RA layers.
> - msg = ".*: (Path 'G(/C/E)?' not present|.*G' path not found)"
> + msg = ".*: (Path 'G(/C/E)?' not present|.*G(/C/E)' path not found)"
>
> # Expect failure on 'svn cp SRC DST' where one or more ancestor
> # directories of DST do not exist
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Mon Oct 22 10:31:15 2007

This is an archived mail posted to the Subversion Dev mailing list.