[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: check-swig-pl broken on trunk?

From: David Summers <david_at_summersoft.fay.ar.us>
Date: 2007-10-22 00:43:42 CEST

Thanks!

That fixed the RPM build problem I was seeing with the PERL bindings
testing.

Will use this patch until it (or subsequent ones) make it in to the repo.

    - David Summers

On Sun, 21 Oct 2007, John Peacock wrote:

> John Peacock wrote:
>>> ------------------------------------------------------------------------
>>> r26241 | kfogel | 2007-08-22 03:01:57 -0400 (Wed, 22 Aug 2007) | 25 lines
>>>
>>> Issue #2882: make 'commit --depth=foo' work.
>
> I've figured out what was wrong; the above patch changed the API for
> svn_client_commit4, but didn't update svn_client_commit3 to match (since
> *_commit3 is implemented by calling *_commit4). Since there are no core tests
> to exercise the historical commit calls, this went unnoticed for two months. In
> this case, the Perl bindings were merely the "canary in the coal mine" since
> there was nothing that changed them. They just happened to be using an old API
> call, which no longer worked.
>
> The only thing I'm not sure of is whether SVN_DEPTH_INFINITY_OR_FILES or
> SVN_DEPTH_INFINITY_OR_IMMEDIATES is the appropriate match for the old
> non-recursive options. I have to say that I have no idea based on the
> [unhelpful to me] help text in svn/main.c for the obsolete non-recursive option.
>
> John
>
> [[[
> New depth argument for svn_client_commit4 wasn't promoted to
> svn_client_commit3, thus breaking all older commit API calls.
>
> * subversion/libsvn_client/commit.c
> (svn_client_commit3): synthesize depth argument from old recurse argument
> ]]]
>
> Index: subversion/libsvn_client/commit.c
> ===================================================================
> --- subversion/libsvn_client/commit.c (revision 27297)
> +++ subversion/libsvn_client/commit.c (working copy)
> @@ -1770,7 +1770,9 @@
> svn_client_ctx_t *ctx,
> apr_pool_t *pool)
> {
> - return svn_client_commit4(commit_info_p, targets, recurse, keep_locks,
> + svn_depth_t depth = SVN_DEPTH_INFINITY_OR_FILES(recurse);
> +
> + return svn_client_commit4(commit_info_p, targets, depth, keep_locks,
> FALSE, NULL, ctx, pool);
> }
>
>

David Wayne Summers "Linux: Because reboots are for hardware upgrades!"
david_at_summersoft.fay.ar.us PGP Key: http://summersoft.fay.ar.us/~david/pgp.txt
PGP Key fingerprint = 0B44 B118 85CC F4EC 7021 1ED4 1516 5B78 E320 2001

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 22 00:44:13 2007

This is an archived mail posted to the Subversion Dev mailing list.