fsfs recover and missing revprop

I was messing around with fsfs recovery today and if you remove the latest
revprops file and current file, then the recovery will set current to that
revision even though you can't get the revision properties from that file. So
the repository is broken.

I could see this happening with a race between the non-'svnadmin hotcopy'
program backing up the rev file but not the current or revprops file during a
commit, which seems possible given that fsfs writes the rev, revprops and then
the current file in that order.

The rev file is more important then the revprops, so presumably we wouldn't want
to set current to the previous revision and loose the rev, but we should do
something about missing revprops also, at least flag a large warning and provide
a way to fill in some default values.

We could populate a revprops from the previous revprops and increment the
timestamp by one second and fill in default svn:author and svn:log files and ask
the admin to get these fields from a post-commit email. But this sounds messy.

I would rather see no fsfs recovery ability in svn then to have people think
that using a non-svnadmin hotcopy to backup a repository is safe if they can
just run recover on it.

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 20 16:18:20 2007