[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: log/blame -g and old servers

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-10-19 22:14:41 CEST

Mark Phippard wrote:
> On 10/19/07, David Glasser <glasser@davidglasser.net> wrote:
>>> Maybe that is all you have been proposing, in which
>>> case I'd be OK. I just want to use the API from JavaHL and not get an
>>> error or perform extra server roundtrips. By the way, distinguishing
>>> the reason for the error in JavaHL is not always as easy as it sounds.
>> I don't see why getting an error is a problem. Look, here is what you do:
>>
>> static someReturnType mphippardSvnLog(args) {
>> try {
>> return svnLog(args, true);
>> } catch (MergeinfoNotSupportedException e) {
>> return svnLog(args, false);
>> }
>> }
>>
>> What's so hard about that?
>
> Aside from the fact that we do not throw nice exceptions like that,
> nothing. I am talking about the UI not the code. As for the code, I
> will probably have to do something stupid and error prone like match a
> string in an exception message.

Really? The ClientException class contains the specific apr error
number for the generated error. Couldn't you just compare it with the
mergeinfo_not_supported error code (which won't change), instead of
matching the string in the error message?

-Hyrum

Received on Fri Oct 19 22:15:22 2007

This is an archived mail posted to the Subversion Dev mailing list.