[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: log/blame -g and old servers

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-10-19 19:43:04 CEST

David Glasser wrote:
> On 10/12/07, Karl Fogel <kfogel@red-bean.com> wrote:
>> "David Glasser" <glasser@davidglasser.net> writes:
>>> Here's a patch implementing that for ra_svn. (Presumably, the same
>>> patch for DAV will be harder because of the general lack of
>>> capabilities.)
>> As we were discussing in IRC: detecting capabilities will be easier
>> after I commit my patch for issue #2959 (latest patch attached there
>> for inspection).
>
> Now that we have this, do people support adding a mergeinfo capability
> and using this to (among other things) error out on log/blame -g?
>
> I'm not sure what I feel about Mark's argument about wanting to
> hardcode to the -g equivalent. Maybe the svn_client APIs could return
> a boolean saying whether or not mergeinfo was actually used?

My initial reaction was not to produce an error, but now I'm not so
sure. If I run 'log -g' on an unknown server, I'll get different
results, depending on whether that server is pre-1.5 or not. Producing
different results dependent upon server version is Bad (at least in this
case).

I now feel that producing an error here isn't a problem. Clients can
trap the error and take whatever action they feel appropriate, which may
include informing the user, and reissuing the request. I suspect the
command line client would just error out.

Using our capability mechanism would be the cleanest way to implement
this, IMHO.

-Hyrum

Received on Fri Oct 19 19:43:37 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.