Re: os.wait in svntest.main.copy_repos?

On 10/17/07, Philip Martin <philip@codematters.co.uk> wrote:
> "David Glasser" <glasser@davidglasser.net> writes:
>
> > Oh, and also --parallel is broken: it makes a bunch of threads, each
> > of which call popen3 and then wait, but there's no guarantee that the
> > test they wait on will be the test they popen3'd.
>
> It also modifies an array in multiple threads without any locking; I
> posted a mutex patch but then gave up when I encountered the wait
> problem.

From searching, it does appear that .append on a list should be
atomic. However, I think we'll be happier if we just change it to use
Queue. Will work on that now...

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org