[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_opt_parse_path and canonical paths

From: Blair Zajac <blair_at_orcaware.com>
Date: 2007-10-17 07:18:22 CEST

Blair Zajac wrote:
> C. Michael Pilato wrote:
>> Blair Zajac wrote:
>>> I need a version of svn_opt_parse_path() that doesn't canonicalize it's
>>> arguments for relative externals (the scheme relative
>>> //hostname/path/to/repos has it's // collapsed to / so it becomes a
>>> server root relative URL).
>>
>> Could you simply test for "//" before parsing the path, then re-add the
>> extra forward slash after parsing if the prior test returned true?
>
> Yes, but svn_opt_parse_path() always returns canonicalized paths, even
> though its documentation in svn_path.h doesn't say so.
>
> Do you think most users of svn_opt_parse_path() know they can pass in
> uncanonicalized and always get back canonicalized paths? If not, then I
> can relax the code.
>
> I may have to audit all uses of svn_opt_parse_path() and ensure that the
> result is passed through one of the canonicalization functions.

Committed in r27236.

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 17 07:18:47 2007

This is an archived mail posted to the Subversion Dev mailing list.