[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27172 - in trunk/subversion: libsvn_ra_neon libsvn_ra_serf libsvn_ra_svn mod_dav_svn/reports

From: Vlad Georgescu <vgeorgescu_at_gmail.com>
Date: 2007-10-15 20:47:20 CEST

Karl Fogel wrote:
>> --- trunk/subversion/libsvn_ra_neon/fetch.c (original)
>> +++ trunk/subversion/libsvn_ra_neon/fetch.c Sat Oct 13 04:32:03 2007
>> @@ -3079,6 +3050,29 @@
>> report_baton_t *rb;
>> const char *s;
>> svn_stringbuf_t *xml_s;
>> + const svn_delta_editor_t *filter_editor;
>> + void *filter_baton;
>> + svn_boolean_t has_target = *target ? TRUE : FALSE, new_server;
>
> Better to declare 'new_server' on its own line, it's easy to lose
> track of it in the conditional definition preceding it.
>
> Also, instead of 'new_server', how about 'server_supports_depth' or
> something? These servers won't always be "new"... someday, they'll
> even be "old" :-).

Thanks for the review. I made these changes in r27193.

-- 
Vlad
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Oct 15 20:47:37 2007

This is an archived mail posted to the Subversion Dev mailing list.