[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26888 - in trunk/subversion: bindings/swig/ruby/libsvn_swig_ruby include libsvn_client libsvn_ra libsvn_ra_svn libsvn_repos libsvn_wc svn svnserve

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-10-14 19:23:25 CEST

On 10/14/07, Karl Fogel <kfogel@red-bean.com> wrote:
> "David Glasser" <glasser@davidglasser.net> writes:
> > I noticed that there is still a lot of custom DEPTH_TO_RECURSE in
> > libsvn_ra_svn/client.c. Is this OK?
>
> Yep, the comment there explains why:
>
> /* We aren't using SVN_DEPTH_IS_RECURSIVE here because that macro (for
> whatever reason) deems svn_depth_immediates as non-recursive, which
> is ... kinda true, but not true enough for our purposes. We need
> our requested recursion level to be *at least* as recursive as the
> real depth we're looking for.
> */
> #define DEPTH_TO_RECURSE(d) \
> (((d) == svn_depth_unknown || (d) > svn_depth_files) ? TRUE : FALSE)

Ah, OK, I thought that that was a very old comment from before we made
those changes. (I still don't quite see why svnserve needs to have
different semantics from everything else...)

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 14 19:23:38 2007

This is an archived mail posted to the Subversion Dev mailing list.