[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn checkpoint: r27139 - checkpoints

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-10-14 16:44:54 CEST

"C. Michael Pilato" <cmpilato@collab.net> writes:
> Exactly. You can't see the diffs when Karl squirrels away patches in his
> local disk, either, and that's fine. What matters is the change dropped
> into a live branch -- that's the diff to review. If Karl wants early
> feedback on his work in progress, then he needs to use a regular feature
> branch and work within the established policies for commits to our tree.

Things are not quite so easily defined, I think.

For example, attaching successive patches to an issue has never part
of our process, but I've been doing it (for off-site backups, and to
provide review opportunities to anyone intensely interested in that
issue's progress).

90% of the time, I'm the only one watching those patches. But every
now and then, I do get reviews, and they're helpful (it happened most
recently in issue #2959, with both dlr and vgeorgescu). Did I "want"
those reviews? Well, I didn't expect them, but I was glad to get
them.

So there can be fine gradations of desire/need for review. I think
Justin's instincts are right, that if there's going to be a review
opportunity at all, we should at least try to make it easy.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Oct 14 16:45:06 2007

This is an archived mail posted to the Subversion Dev mailing list.