C. Michael Pilato wrote:
> Ben Collins-Sussman wrote:
>> On 10/13/07, lgo@tigris.org <lgo@tigris.org> wrote:
>>> Author: lgo
>>> Date: Sat Oct 13 03:49:30 2007
>>> New Revision: 27170
>>>
>>> Log:
>>> Fix fetching a file from the server during copy-on-update over ra_neon &
>>> ra_serf.
>>>
>>> * subversion/libsvn_wc/update_editor.c
>>> (add_file_with_history): copyfrom_path is absolute but fetch_func requires
>>> a relative path, so skip the first '/'.
>>>
>>>
>>> Modified:
>>> trunk/subversion/libsvn_wc/update_editor.c
>>>
>>> Modified: trunk/subversion/libsvn_wc/update_editor.c
>>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_wc/update_editor.c?pathrev=27170&r1=27169&r2=27170
>>> ==============================================================================
>>> --- trunk/subversion/libsvn_wc/update_editor.c (original)
>>> +++ trunk/subversion/libsvn_wc/update_editor.c Sat Oct 13 03:49:30 2007
>>> @@ -3061,7 +3061,9 @@
>>> (APR_WRITE | APR_TRUNCATE | APR_CREATE),
>>> pool));
>>>
>>> - SVN_ERR(eb->fetch_func(eb->fetch_baton, copyfrom_path, copyfrom_rev,
>>> + /* copyfrom_path is a absolute path, fetch_func requires a path relative
>>> + to the root of the repository so skip the first '/'. */
>>> + SVN_ERR(eb->fetch_func(eb->fetch_baton, copyfrom_path + 1, copyfrom_rev,
>>> svn_stream_from_aprfile(textbase_file, pool),
>>> NULL, &base_props, pool));
>>> }
>>
>> I'm trying to grok this change. Is it true that each RA layer sends a
>> copyfrom_path to the update_editor which starts with '/'? If so,
>> that's good.
It seems so, I tested it with all ra_ layer and the behavior is
consistent. So while we need a relative path to call the functions in
the ra layer, the paths returned from the layer are absolute. In this
case, the copyfrom_path is copied unchanged from the XML report.
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 13 17:14:15 2007