Re: [PATCH] svnserve: write pid a bit earlier?

Eric Gillespie <epg@pretzelnet.org> writes:

> "David Glasser" <glasser@davidglasser.net> writes:
>
> > svnserve -d -r bla --pid-file .svnserve-pid
> > spid=`cat .svnserve-pid`
> > run some tests
> > kill -9 $spid
>
> I don't object to your change, but all you do is shorten the
> race: it's inherent in the pidfile practice. What you want is:
>
> svnserve -d -r bla --foreground &
> spid=$!
> run some tests
> kill -9 $spid

Now that I think about it, I think your patch is broken. You
write the PID of the svnserve you started, but it then forks off
the one that hangs around. I have not tested this, or even
looked up apr_proc_detach, so I may be wrong.

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org