[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27097 - trunk/subversion/libsvn_fs_fs

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-10-11 11:33:17 CEST

On Wed, Oct 10, 2007 at 04:02:37PM -0700, glasser@tigris.org wrote:
> Move the cache of *immutable* DAG noderevs from revision roots to the
> svn_fs_t object. This extends the lifetime of cache entries; in my
> test, a somewhat large diff operation on a repository in NFS got a 4x
> speedup. Transaction DAG noderevs are still in the roots (though
> perhaps this should change).
>

Nice change! Is it worth considering whether this cache can go into the
per-filesystem object (fs_fs_shared_data_t) instead of the
per-filesystem-handle object (fs_fs_data_t)?

Obviously you'd have to add some locking, but it would help to ensure
that we can still benefit from the cache when we open a new handle.

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Thu Oct 11 11:34:11 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.