[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Don't link some Subversion libraries against unneeded external libraries

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2007-10-07 17:40:32 CEST

On Oct 6, 2007 11:00 AM, Arfrever Frehtes Taifersar Arahesis
<arfrever.fta@gmail.com> wrote:
> 2007-10-06 00:00:09 Arfrever Frehtes Taifersar Arahesis napisał(a):
> > Currently Subversion libraries are linked against all external libraries used
> > by APR/APR-Util, but Subversion really uses only a subset of these libraries.
>
> I'm attaching the updated version of this patch.

Hardcoding '-lexpat' is a poor idea - older Debian uses "-lxmlparse
-lxmltok", so this will break configurations that would have otherwise
worked.

This will also break with older versions of GNU libtool (1.4.x) on
platforms where you must include all possible libraries on the link
line and/or produce static binaries. (libtool didn't always do
transitive linking correctly on platforms that required that; and
still doesn't, AFAIK, for static binaries.)

Additionally, APR-util also pulls in sqlite (which we use as well), so
if we drop that, we could all too easily end up with yet another
library mismatch at run-time. -- justin
Received on Sun Oct 7 17:40:41 2007

This is an archived mail posted to the Subversion Dev mailing list.